[
https://issues.apache.org/jira/browse/HBASE-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198501#comment-15198501
]
Geoffrey Jacoby commented on HBASE-12940:
-----------------------------------------
Despite the name, none of the existing or new tests in TestReplicationShell
actually test the replication _shell_. Instead they test the Ruby class,
replication_admin.rb, that the replication shell commands call.
The code you quote has no unit test associated with it (and neither do the
other existing Ruby commands in ruby/shell/commands, unless I've missed
something. There are just a few basic sanity checks in test/ruby/shell/)
To verify the code I added in ruby/shell/commands, I built HBase, ran in local
mode and manually used the hbase shell to add two different kinds of peers (a
basic one with just a cluster key, and a more complicated one with a custom
replication endpoint class and a config dictionary). Then I verified that
get_peer_config and list_peer_configs, the two new methods worked as expected.
> Expose listPeerConfigs and getPeerConfig to the HBase shell
> -----------------------------------------------------------
>
> Key: HBASE-12940
> URL: https://issues.apache.org/jira/browse/HBASE-12940
> Project: HBase
> Issue Type: Bug
> Components: shell
> Reporter: Kevin Risden
> Assignee: Geoffrey Jacoby
> Attachments: HBASE-12940-v1.patch, HBASE-12940.patch
>
>
> In HBASE-12867 found that listPeerConfigs and getPeerConfig from
> ReplicationAdmin are not exposed to the HBase shell. This makes looking at
> details for custom replication endpoints and testing of add_peer from
> HBASE-12867 impossible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
