[jira] [Commented] (HBASE-15485) Filter.reset() should not be called between batches

[Phil Yang (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-15485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15219359#comment-15219359
 ] 

Phil Yang commented on HBASE-15485:
-----------------------------------

In RegionScannerImpl.populateResult, we can add this:
{code}
           if (!moreCellsInRow) 
incrementCountOfRowsScannedMetric(scannerContext);
-          if (scannerContext.checkBatchLimit(limitScope)) {
+          if (moreCellsInRow && scannerContext.checkBatchLimit(limitScope)) {
             return 
scannerContext.setScannerState(NextState.BATCH_LIMIT_REACHED).hasMoreValues();
{code}

It will pass the test I added (not included in v1 patch), have not run all 
tests.

> Filter.reset() should not be called between batches
> ---------------------------------------------------
>
>                 Key: HBASE-15485
>                 URL: https://issues.apache.org/jira/browse/HBASE-15485
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.2.0, 1.1.3
>            Reporter: Phil Yang
>            Assignee: Phil Yang
>         Attachments: HBASE-15485-v1.patch
>
>
> As discussed in HBASE-15325, now we will resetFilters if partial result not 
> formed, but we should not reset filters when batch limit reached



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)