[
https://issues.apache.org/jira/browse/HBASE-15485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15219467#comment-15219467
]
Anoop Sam John commented on HBASE-15485:
----------------------------------------
Nice. +1
Minor comments on test
bq.private final static int MINICLUSTER_SIZE = 5;
Why we need 5 RSs for this Filter tests? 1 is ok? Will save some time as we
dont have to start more RS threads in the test.
bq.TableName.valueOf("testTable");
Use same name as the test class?
> Filter.reset() should not be called between batches
> ---------------------------------------------------
>
> Key: HBASE-15485
> URL: https://issues.apache.org/jira/browse/HBASE-15485
> Project: HBase
> Issue Type: Bug
> Affects Versions: 1.2.0, 1.1.3
> Reporter: Phil Yang
> Assignee: Phil Yang
> Attachments: HBASE-15485-v1.patch, HBASE-15485-v2.patch
>
>
> As discussed in HBASE-15325, now we will resetFilters if partial result not
> formed, but we should not reset filters when batch limit reached
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
