[
https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228103#comment-15228103
]
ramkrishna.s.vasudevan commented on HBASE-15174:
------------------------------------------------
Following the suggestion by Enis, I got this following files and methods that
needs to be addressed as part of this JIRA
{code}
org.apache.hadoop.hbase.snapshot.SnapshotDoesNotExistException
getSnapshotDescription()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$SnapshotDescription
org.apache.hadoop.hbase.ServerLoad obtainServerLoadPB()
org.apache.hadoop.hbase.protobuf.generated.ClusterStatusProtos$ServerLoad
org.apache.hadoop.hbase.client.UnmodifyableHTableDescriptor convert()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$TableSchema
org.apache.hadoop.hbase.snapshot.SnapshotExistsException
getSnapshotDescription()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$SnapshotDescription
org.apache.hadoop.hbase.ipc.RemoteWithExtrasException getErrorCode()
org.apache.hadoop.ipc.protobuf.RpcHeaderProtos$RpcResponseHeaderProto$RpcErrorCodeProto
org.apache.hadoop.hbase.snapshot.SnapshotCreationException
getSnapshotDescription()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$SnapshotDescription
org.apache.hadoop.hbase.ProcedureInfo getForeignExceptionMessage()
org.apache.hadoop.hbase.protobuf.generated.ErrorHandlingProtos$ForeignExceptionMessage
org.apache.hadoop.hbase.ProcedureInfo getProcState()
org.apache.hadoop.hbase.protobuf.generated.ProcedureProtos$ProcedureState
org.apache.hadoop.hbase.client.coprocessor.DoubleColumnInterpreter initialize()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$EmptyMsg
org.apache.hadoop.hbase.client.coprocessor.DoubleColumnInterpreter
getCellValueFromProto()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$DoubleMsg
org.apache.hadoop.hbase.client.coprocessor.DoubleColumnInterpreter
getPromotedValueFromProto()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$DoubleMsg
org.apache.hadoop.hbase.client.coprocessor.DoubleColumnInterpreter
getProtoForCellType()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$DoubleMsg
org.apache.hadoop.hbase.client.coprocessor.DoubleColumnInterpreter
getProtoForPromotedType()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$DoubleMsg
org.apache.hadoop.hbase.client.coprocessor.DoubleColumnInterpreter
getRequestData() org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$EmptyMsg
org.apache.hadoop.hbase.ClusterStatus convert()
org.apache.hadoop.hbase.protobuf.generated.ClusterStatusProtos$ClusterStatus
org.apache.hadoop.hbase.snapshot.CorruptedSnapshotException
getSnapshotDescription()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$SnapshotDescription
org.apache.hadoop.hbase.snapshot.HBaseSnapshotException
getSnapshotDescription()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$SnapshotDescription
org.apache.hadoop.hbase.snapshot.UnknownSnapshotException
getSnapshotDescription()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$SnapshotDescription
org.apache.hadoop.hbase.HTableDescriptor convert()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$TableSchema
org.apache.hadoop.hbase.client.HConnection getClient()
org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$BlockingInterface
org.apache.hadoop.hbase.client.HConnection getAdmin()
org.apache.hadoop.hbase.protobuf.generated.AdminProtos$AdminService$BlockingInterface
org.apache.hadoop.hbase.client.HConnection getAdmin()
org.apache.hadoop.hbase.protobuf.generated.AdminProtos$AdminService$BlockingInterface
org.apache.hadoop.hbase.client.HConnection getMaster()
org.apache.hadoop.hbase.protobuf.generated.MasterProtos$MasterService$BlockingInterface
org.apache.hadoop.hbase.snapshot.ExportSnapshotException
getSnapshotDescription()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$SnapshotDescription
org.apache.hadoop.hbase.HColumnDescriptor convert()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$ColumnFamilySchema
org.apache.hadoop.hbase.client.Result getStats()
org.apache.hadoop.hbase.protobuf.generated.ClientProtos$RegionLoadStats
org.apache.hadoop.hbase.client.Result addResults()
org.apache.hadoop.hbase.protobuf.generated.ClientProtos$RegionLoadStats
org.apache.hadoop.hbase.client.Result setStatistics()
org.apache.hadoop.hbase.protobuf.generated.ClientProtos$RegionLoadStats
org.apache.hadoop.hbase.snapshot.RestoreSnapshotException
getSnapshotDescription()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$SnapshotDescription
org.apache.hadoop.hbase.client.Admin snapshot()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$SnapshotDescription$Type
org.apache.hadoop.hbase.client.Admin snapshot()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$SnapshotDescription
org.apache.hadoop.hbase.client.Admin isSnapshotFinished()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$SnapshotDescription
org.apache.hadoop.hbase.client.Admin getCompactionStateForRegion()
org.apache.hadoop.hbase.protobuf.generated.AdminProtos$GetRegionInfoResponse$CompactionState
org.apache.hadoop.hbase.client.Admin takeSnapshotAsync()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$SnapshotDescription
org.apache.hadoop.hbase.client.Admin getCompactionState()
org.apache.hadoop.hbase.protobuf.generated.AdminProtos$GetRegionInfoResponse$CompactionState
org.apache.hadoop.hbase.client.Admin getCompactionState()
org.apache.hadoop.hbase.protobuf.generated.AdminProtos$GetRegionInfoResponse$CompactionState
{code}
> Client Public API should not have PB objects in 2.0
> ---------------------------------------------------
>
> Key: HBASE-15174
> URL: https://issues.apache.org/jira/browse/HBASE-15174
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 2.0.0
>
>
> Some more cleanup for the parent jira.
> We have leaked some PB structs in Admin (and possible other places).
> We should clean up these API before 2.0.
> Examples include:
> {code}
> AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final
> TableName tableName)
> throws IOException;
>
> ....
> void snapshot(final String snapshotName,
> final TableName tableName,
> HBaseProtos.SnapshotDescription.Type type) throws IOException,
> SnapshotCreationException,
> IllegalArgumentException;
> ....
> MasterProtos.SnapshotResponse
> takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot)
> throws IOException, SnapshotCreationException;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
