[ https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229147#comment-15229147 ]
Sean Busbey commented on HBASE-15174: ------------------------------------- {quote} All convert methods, ex. org.apache.hadoop.hbase.ClusterStatus convert() can go to ProtobufUtil, so that they are not part of the public API. {quote} This is not necessary. We can just annotate the methods with IA.Private to denote that they aren't in the public API. > Client Public API should not have PB objects in 2.0 > --------------------------------------------------- > > Key: HBASE-15174 > URL: https://issues.apache.org/jira/browse/HBASE-15174 > Project: HBase > Issue Type: Sub-task > Reporter: Enis Soztutar > Assignee: ramkrishna.s.vasudevan > Priority: Blocker > Fix For: 2.0.0 > > > Some more cleanup for the parent jira. > We have leaked some PB structs in Admin (and possible other places). > We should clean up these API before 2.0. > Examples include: > {code} > AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final > TableName tableName) > throws IOException; > > .... > void snapshot(final String snapshotName, > final TableName tableName, > HBaseProtos.SnapshotDescription.Type type) throws IOException, > SnapshotCreationException, > IllegalArgumentException; > .... > MasterProtos.SnapshotResponse > takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot) > throws IOException, SnapshotCreationException; > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)