[ 
https://issues.apache.org/jira/browse/HBASE-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228580#comment-15228580
 ] 

Weiqing Yang commented on HBASE-15572:
--------------------------------------

[~busbey]       Hi, Sean 
I tried to add descriptions in spark.adoc and submitted several times but 
failed, e.g. HBASE-15572-8.patch. HBASE-15572-7.patch is the version without 
doc update, which passed all the tests. The only difference between 
HBASE-15572-8.patch and HBASE-15572-7.patch as following:
------------------------
diff --git src/main/asciidoc/_chapters/spark.adoc 
src/main/asciidoc/_chapters/spark.adoc
index b1bdb5d..9148ce2 100644
--- src/main/asciidoc/_chapters/spark.adoc
+++ src/main/asciidoc/_chapters/spark.adoc
@@ -395,6 +395,11 @@ The HBase-Spark module includes support for Spark SQL and 
DataFrames, which allo
 you to write SparkSQL directly on HBase tables. In addition the HBase-Spark
 will push down query filtering logic to HBase.
 
+Users can query records with different timestamps or time ranges with
+minimum timestamp and maximum timestamp. In HBaseSparkConf, the hbase 
configuration,
+four parameters related to timestamp can be set: timestamp, minTimestamp,
+maxiTimestamp and maxVersions.
+
---------------------
I am new to contribute the apache community. Could you please help to check if 
the error is from the test system itself or from my patch? I think my patch is 
small and safe which just add timestamps to let users select different 
timestamps or time ranges. Thank you very much for your help.

> Adding optional timestamp semantics to HBase-Spark
> --------------------------------------------------
>
>                 Key: HBASE-15572
>                 URL: https://issues.apache.org/jira/browse/HBASE-15572
>             Project: HBase
>          Issue Type: New Feature
>          Components: spark
>            Reporter: Weiqing Yang
>            Assignee: Weiqing Yang
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15572-1.patch, HBASE-15572-2.patch, 
> HBASE-15572-3.patch, HBASE-15572-4.patch, HBASE-15572-5.patch, 
> HBASE-15572-6.patch, HBASE-15572-7.patch, HBASE-15572-8.patch
>
>
> Right now the timestamp is always latest. With this patch, users can select 
> timestamps they want.
> In this patch, 4 parameters, "timestamp", "minTimestamp", "maxiTimestamp" and 
> "maxVersions" are added to HBaseSparkConf. Users can select a timestamp, they 
> can also select a time range with minimum timestamp and maximum timestamp. A 
> new test for selecting records with different timestamps is added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to