[
https://issues.apache.org/jira/browse/HBASE-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228702#comment-15228702
]
Sean Busbey commented on HBASE-15572:
-------------------------------------
the unit test failures aren't related to your patch.
The text blurb is a good start, but a code example will make it clearer (as
most of the other spark feature explanations do in the ref guide). Since this
will involve more prose explaining the examples this should probably be a
subsection rather than a standalone paragraph.
Looking at the patch and the existing examples I have a few additional
questions:
* As new constants in HBaseSparkConf, the names need to be scoped rather than
bare as e.g. 'timestamp' should be 'hbase.spark.query.timestamp' (or something
similar within the 'hbase.spark' prefix).
* Does this only let folks choose timestamp ranges in SparkSQL? Or does it also
work for the other HBase query mechanisms, like [the hBaseRDD described in the
Basic Spark section of the ref
guide|http://hbase.apache.org/book.html#_basic_spark]?
> Adding optional timestamp semantics to HBase-Spark
> --------------------------------------------------
>
> Key: HBASE-15572
> URL: https://issues.apache.org/jira/browse/HBASE-15572
> Project: HBase
> Issue Type: New Feature
> Components: spark
> Reporter: Weiqing Yang
> Assignee: Weiqing Yang
> Fix For: 2.0.0
>
> Attachments: HBASE-15572-1.patch, HBASE-15572-2.patch,
> HBASE-15572-3.patch, HBASE-15572-4.patch, HBASE-15572-5.patch,
> HBASE-15572-6.patch, HBASE-15572-7.patch, HBASE-15572-8.patch
>
>
> Right now the timestamp is always latest. With this patch, users can select
> timestamps they want.
> In this patch, 4 parameters, "timestamp", "minTimestamp", "maxiTimestamp" and
> "maxVersions" are added to HBaseSparkConf. Users can select a timestamp, they
> can also select a time range with minimum timestamp and maximum timestamp. A
> new test for selecting records with different timestamps is added.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
