[
https://issues.apache.org/jira/browse/HBASE-15525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15234529#comment-15234529
]
Anoop Sam John commented on HBASE-15525:
----------------------------------------
Clean way is to return the BB to pool in same place where it was obtained.
That is why kept in the OS. To keep in BufferChain, the main thing is to know
whether a BB came from pool or not. When the pool is not having BB now, we will
make a new temp one. All these details are kept in one place now. Also we
might want the pool BBs to read reqs into also.
We would want the users to tune the max #BBs so that there is enough off heap
BBs in pool to handle the reqs. Ya it can so happen that on a high load case,
it may go out of size. But IMHO its ok to have temp byte[]s these are very
short lived and in most chance will get cleaned in Young GC. No need to have
extra complex things like weak ref based another pooling. If it comes out as
a need later, we can handle then. As of now keep it small and simple.
> OutOfMemory could occur when using BoundedByteBufferPool during RPC bursts
> --------------------------------------------------------------------------
>
> Key: HBASE-15525
> URL: https://issues.apache.org/jira/browse/HBASE-15525
> Project: HBase
> Issue Type: Sub-task
> Components: IPC/RPC
> Reporter: deepankar
> Assignee: Anoop Sam John
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-15525_V1.patch, HBASE-15525_V2.patch,
> HBASE-15525_WIP.patch, WIP.patch
>
>
> After HBASE-13819 the system some times run out of direct memory whenever
> there is some network congestion or some client side issues.
> This was because of pending RPCs in the RPCServer$Connection.responseQueue
> and since all the responses in this queue hold a buffer for cellblock from
> BoundedByteBufferPool this could takeup a lot of memory if the
> BoundedByteBufferPool's moving average settles down towards a higher value
> See the discussion here
> [HBASE-13819-comment|https://issues.apache.org/jira/browse/HBASE-13819?focusedCommentId=15207822&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15207822]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
