[ 
https://issues.apache.org/jira/browse/HBASE-15454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240632#comment-15240632
 ] 

Clara Xiong commented on HBASE-15454:
-------------------------------------

Ah, after reading your last comment and the code, now I understand what you are 
trying to achieve in this patch. Would you mind updating the ticket description 
because it could be really confusing?

You are using a special type of minor compaction to make sure all data falling 
into an archive window are compacted into a file.  You piggy-back on minor 
compaction triggering which needs closer attention. 1. We have to make sure you 
get all the files. I know you check fileCompacting.But there are other checks, 
please refer to the logic when we try to do major compaction. 2. We have to 
avoid re-compaction. maxAge is better set to a number we know additional data 
will not arrive after this compaction. 3. We need to make sure this doesn't get 
starved by frequent minor compactions. 4. How do we know a store file is ready 
to be archived? Do we set a flag after this special minor compaction?

There could be other edge cases. Let me think more.

> Archive store files older than max age
> --------------------------------------
>
>                 Key: HBASE-15454
>                 URL: https://issues.apache.org/jira/browse/HBASE-15454
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Compaction
>    Affects Versions: 2.0.0, 1.3.0, 0.98.18, 1.4.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0, 1.3.0, 0.98.19, 1.4.0
>
>         Attachments: HBASE-15454-v1.patch, HBASE-15454-v2.patch, 
> HBASE-15454.patch
>
>
> Sometimes the old data is rarely touched but we can not remove it. So archive 
> it to several big files(by year or something) and use EC to reduce the 
> redundancy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to