[
https://issues.apache.org/jira/browse/HBASE-15650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15242432#comment-15242432
]
Anoop Sam John commented on HBASE-15650:
----------------------------------------
+1 Great...
{code}
public void includeTimestamp(final Cell cell) {
92 // TODO: Why is this necessary? We already did this when we added
the Cells to the memstore.
93 // Won't this run-through just do nothing except slow us down?
94 includeTimestamp(cell.getTimestamp());
{code}
I see this TODO added.. When Cell is added to memstore, we call
Segment#updateMetaInfo(Cell toAdd, long s) which call this method on TRT
passing the Cell.. So ya when we add cell to memstore, we are doing this via
this method.. I think no issue here and better remove this TODO also.
> Remove TimeRangeTracker as point of contention when many threads reading a
> StoreFile
> ------------------------------------------------------------------------------------
>
> Key: HBASE-15650
> URL: https://issues.apache.org/jira/browse/HBASE-15650
> Project: HBase
> Issue Type: Bug
> Components: Performance
> Affects Versions: 2.0.0
> Reporter: stack
> Assignee: stack
> Fix For: 2.0.0
>
> Attachments: 15650.branch-1.patch, 15650.patch, 15650.patch,
> 15650v2.patch, 15650v3.patch, 15650v4.patch, 15650v5.patch,
> Point-of-contention-on-random-read.png
>
>
> HBASE-12148 is about "Remove TimeRangeTracker as point of contention when
> many threads writing a Store". It is also a point of contention when reading.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
