[ 
https://issues.apache.org/jira/browse/HBASE-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151780#comment-13151780
 ] 

Lars Hofhansl commented on HBASE-4805:
--------------------------------------

Will undo the formatting (Eclipse did that with the HBase formatter).
Configuration is still used to get conf settings. (That strange null check for 
it was in there before - note sure what use the HTable is if null is passed for 
Configuration).

Was thinking about getting the conf from the HConnection as well, but then it 
needed some more refactoring and I wanted a simple patch.

Hmm... Let me see what I can come up with. The HConnection's conf and the 
passed conf could be different and that would be... Bad.

                
> Allow better control of resource consumption in HTable
> ------------------------------------------------------
>
>                 Key: HBASE-4805
>                 URL: https://issues.apache.org/jira/browse/HBASE-4805
>             Project: HBase
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.92.0, 0.94.0
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.94.0
>
>         Attachments: 4805.txt
>
>
> From some internal discussions at Salesforce we concluded that we need better 
> control over the resources (mostly threads) consumed by HTable when used in a 
> AppServer with many client threads.
> Since HTable is not thread safe, the only options are cache them (in a custom 
> thread local or using HTablePool) or to create them on-demand.
> I propose a simple change: Add a new constructor to HTable that takes an 
> optional ExecutorService and HConnection instance. That would make HTable a 
> pretty lightweight object and we would manage the ES and HC separately.
> I'll upload a patch a soon to get some feedback.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to