[ 
https://issues.apache.org/jira/browse/HBASE-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151789#comment-13151789
 ] 

Ted Yu commented on HBASE-4805:
-------------------------------

If conf is passed and HConnection isn't null, we should check their equality by 
virtue of HConnectionKey.CONNECTION_PROPERTIES

Maybe we can put HConnectionKey in its own class file and expose equality check 
by comparing conf values for the elements of 
HConnectionKey.CONNECTION_PROPERTIES

If conf and HConnection's configuration aren't equal according to the above 
check, throw exception in HTable ctor.
                
> Allow better control of resource consumption in HTable
> ------------------------------------------------------
>
>                 Key: HBASE-4805
>                 URL: https://issues.apache.org/jira/browse/HBASE-4805
>             Project: HBase
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.92.0, 0.94.0
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.94.0
>
>         Attachments: 4805.txt
>
>
> From some internal discussions at Salesforce we concluded that we need better 
> control over the resources (mostly threads) consumed by HTable when used in a 
> AppServer with many client threads.
> Since HTable is not thread safe, the only options are cache them (in a custom 
> thread local or using HTablePool) or to create them on-demand.
> I propose a simple change: Add a new constructor to HTable that takes an 
> optional ExecutorService and HConnection instance. That would make HTable a 
> pretty lightweight object and we would manage the ES and HC separately.
> I'll upload a patch a soon to get some feedback.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to