[ 
https://issues.apache.org/jira/browse/HBASE-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152156#comment-13152156
 ] 

stack commented on HBASE-4805:
------------------------------

bq. Could add a public createConnection(Configuration) method to HCM to 
completely bypass the connection caching... It's not really needed for our 
purposes....

I've been tempted to do this a bunch of times but have not yet had a good 
enough reason (recently I changed internals of HCM so could get at them from 
same package to help w/ mocking -- so I could insert a mocked HConnection under 
HTable).  I'd say leave it as is till we have a good reason.

+1 on patch

Set this.connection to null after you close it when you commit the patch?

{code}
+      if (this.connection != null) {
+        this.connection.close();
{code}

                
> Allow better control of resource consumption in HTable
> ------------------------------------------------------
>
>                 Key: HBASE-4805
>                 URL: https://issues.apache.org/jira/browse/HBASE-4805
>             Project: HBase
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.92.0, 0.94.0
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.92.0, 0.94.0
>
>         Attachments: 4805-v2.txt, 4805.txt
>
>
> From some internal discussions at Salesforce we concluded that we need better 
> control over the resources (mostly threads) consumed by HTable when used in a 
> AppServer with many client threads.
> Since HTable is not thread safe, the only options are cache them (in a custom 
> thread local or using HTablePool) or to create them on-demand.
> I propose a simple change: Add a new constructor to HTable that takes an 
> optional ExecutorService and HConnection instance. That would make HTable a 
> pretty lightweight object and we would manage the ES and HC separately.
> I'll upload a patch a soon to get some feedback.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to