[ 
https://issues.apache.org/jira/browse/HBASE-15737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265136#comment-15265136
 ] 

Sean Busbey commented on HBASE-15737:
-------------------------------------

bq. Our codebase should be consistent w.r.t. the usage of stop watch.

I don't understand, why? We set a goal of removing it from hbase-client for a 
very specific reason. The issue wasn't Stopwatch, it was that there were Guava 
things at all.

What is the issue with making use of a class that's been present since Guava 10 
and AFAICT is still present in the current Guava SNAPSHOT?  Is the issue that 
it's annotated Beta? Should we be removing Beta annotated Guava use entirely?

> Remove use of Guava Stopwatch
> -----------------------------
>
>                 Key: HBASE-15737
>                 URL: https://issues.apache.org/jira/browse/HBASE-15737
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: 15737.v1.txt
>
>
> HBASE-14963 removed reference to Guava Stopwatch from hbase-client module.
> However, there're still 3 classes referring to Guava Stopwatch :
> hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java:import
>  com.google.common.base.Stopwatch;
> hbase-server/src/main/java/org/apache/hadoop/hbase/util/JvmPauseMonitor.java:import
>  com.google.common.base.Stopwatch;
> hbase-server/src/test/java/org/apache/hadoop/hbase/ScanPerformanceEvaluation.java:import
>  com.google.common.base.Stopwatch;
> We should remove reference to Guava Stopwatch.
> hadoop is no longer referencing Guava Stopwatch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to