[
https://issues.apache.org/jira/browse/HBASE-15737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267247#comment-15267247
]
stack commented on HBASE-15737:
-------------------------------
bq. I didn't use format-patch - I would be integrating the patch myself.
Eh. The format-patch guidelines are for all contributors and especially for
committers who are supposed to be setting an example with good practice for
contributors to follow.
Also, this patch is going in the wrong direction. Guava is a high-quality
library, actively maintained, that we should be doubling down on, not purging
from our code base. Your time would be better spent working on shading the
Guava lib -- as suggested in HBASE-14963 -- so the project feels secure making
use of Guava.
> Remove use of Guava Stopwatch
> -----------------------------
>
> Key: HBASE-15737
> URL: https://issues.apache.org/jira/browse/HBASE-15737
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Minor
> Attachments: 15737.v1.txt, 15737.v2.txt, 15737.v3.txt
>
>
> HBASE-14963 removed reference to Guava Stopwatch from hbase-client module.
> However, there're still 3 classes referring to Guava Stopwatch :
> hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java:import
> com.google.common.base.Stopwatch;
> hbase-server/src/main/java/org/apache/hadoop/hbase/util/JvmPauseMonitor.java:import
> com.google.common.base.Stopwatch;
> hbase-server/src/test/java/org/apache/hadoop/hbase/ScanPerformanceEvaluation.java:import
> com.google.common.base.Stopwatch;
> We should remove reference to Guava Stopwatch.
> hadoop is no longer referencing Guava Stopwatch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
