[
https://issues.apache.org/jira/browse/HBASE-15763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269728#comment-15269728
]
Ted Yu commented on HBASE-15763:
--------------------------------
{code}
51 @InterfaceAudience.Private
52 public class MasterWalManager {
{code}
Please add class javadoc
{code}
112 public void stop() {
113 if (splitLogManager != null) {
114 this.splitLogManager.stop();
115 }
{code}
Should splitLogManager be set to null after the call to stop() ?
Some methods can be package private. e.g.:
{code}
127 public Path getOldLogDir() {
{code}
> Isolate Wal related stuff from MasterFileSystem
> -----------------------------------------------
>
> Key: HBASE-15763
> URL: https://issues.apache.org/jira/browse/HBASE-15763
> Project: HBase
> Issue Type: Sub-task
> Components: master, wal
> Affects Versions: 2.0.0
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Priority: Trivial
> Fix For: 2.0.0
>
> Attachments: HBASE-15763-v0.patch
>
>
> To help the work on the redofs (HBASE-14090) we need some rework on the
> "filesystem" interfaces.
> This task just moves the WAL related things out of MasterFileSystem.
> This task is not meant to create a good interface for the wal but just to
> move out things from MasterFileSystem to be able to start working on that.
> the fixup of the wal interface will be done later in another jira.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
