[ 
https://issues.apache.org/jira/browse/HBASE-15763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269838#comment-15269838
 ] 

Matteo Bertozzi commented on HBASE-15763:
-----------------------------------------

splitLogManager is final, I don't really want to change that just to set it to 
null. we know that we will never call it twice since the master code will do 
that. also splitLogManager.stop() is implemented in the same way without the 
nulls. I don't really want to change everything. 
and as mentioned in the description this patch is just moving out code without 
any changes. 

getOldLogDir() is used by the Master, so we can't make it private. same the 
others are all used by master, serverCrash or other. The only one seems to be 
checkFileSystem() I'll make that private.

> Isolate Wal related stuff from MasterFileSystem
> -----------------------------------------------
>
>                 Key: HBASE-15763
>                 URL: https://issues.apache.org/jira/browse/HBASE-15763
>             Project: HBase
>          Issue Type: Sub-task
>          Components: master, wal
>    Affects Versions: 2.0.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Trivial
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15763-v0.patch, HBASE-15763-v1.patch
>
>
> To help the work on the redofs (HBASE-14090) we need some rework on the 
> "filesystem" interfaces.
> This task just moves the WAL related things out of MasterFileSystem.
> This task is not meant to create a good interface for the wal but just to 
> move out things from MasterFileSystem to be able to start working on that. 
> the fixup of the wal interface will be done later in another jira. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to