[
https://issues.apache.org/jira/browse/HBASE-15554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15293632#comment-15293632
]
stack commented on HBASE-15554:
-------------------------------
The HasKey goes to far. How many Interfaces do we have currently around Cell
and KeyValue? It might be worth listing them? Up to this we had Cell and we had
Cell with empty value. Key is new concept, or rather, it is an old one in that
we always just kept Key in indices and blooms... and you are trying to
formalize it now? Does a Cell have a Key? KeyValue has a Key (makes sense). If
anything the Interface shoudl be called Key? So, we have getKeyArray and offset
and length. Do the latter work if a byte [] or BB? In same way as ServerCell?
But thinking on it, what is a Key? You can ask it for family and qualifier
pieces? And timestamps? You use the Cell APIs to do this against a Key?
2.0 is not out yet. You fellows have learned a lot in this area over the course
of your offheaping work. Maybe there are some type refactorings we could do
that could get rid of a bunch of Interfaces?
> StoreFile$Writer.appendGeneralBloomFilter generates extra KV
> ------------------------------------------------------------
>
> Key: HBASE-15554
> URL: https://issues.apache.org/jira/browse/HBASE-15554
> Project: HBase
> Issue Type: Sub-task
> Components: Performance
> Reporter: Vladimir Rodionov
> Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0
>
> Attachments: HBASE-15554.patch, HBASE-15554_3.patch,
> HBASE-15554_4.patch
>
>
> Accounts for 10% memory allocation in compaction thread when BloomFilterType
> is ROWCOL.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
