[
https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15312810#comment-15312810
]
Enis Soztutar commented on HBASE-15174:
---------------------------------------
Thanks [~ram_krish]. Instead of adding ServerLoadProtosWrapper and
RegionLoadProtosWrapper, we can instead annotate the constructors of RegionLoad
and ServerLoad with InterfaceAudience.Private. The public API for both is for
the users to call various get methods, so constructors can be treated as
private API.
> Client Public API should not have PB objects in 2.0
> ---------------------------------------------------
>
> Key: HBASE-15174
> URL: https://issues.apache.org/jira/browse/HBASE-15174
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-15174.patch, HBASE-15174_1.patch,
> HBASE-15174_2.patch
>
>
> Some more cleanup for the parent jira.
> We have leaked some PB structs in Admin (and possible other places).
> We should clean up these API before 2.0.
> Examples include:
> {code}
> AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final
> TableName tableName)
> throws IOException;
>
> ....
> void snapshot(final String snapshotName,
> final TableName tableName,
> HBaseProtos.SnapshotDescription.Type type) throws IOException,
> SnapshotCreationException,
> IllegalArgumentException;
> ....
> MasterProtos.SnapshotResponse
> takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot)
> throws IOException, SnapshotCreationException;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
