[ https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313726#comment-15313726 ]
Hadoop QA commented on HBASE-15174: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 15s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 8s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 48s {color} | {color:green} master passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s {color} | {color:green} master passed with JDK v1.7.0_79 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 45s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 23s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 40s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 51s {color} | {color:green} master passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 35s {color} | {color:green} master passed with JDK v1.7.0_79 {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 19s {color} | {color:red} hbase-client in the patch failed. {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 51s {color} | {color:green} the patch passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 51s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 17s {color} | {color:red} hbase-client in the patch failed with JDK v1.7.0_79. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 17s {color} | {color:red} hbase-client in the patch failed with JDK v1.7.0_79. {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 45s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 20s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} Patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 0m 35s {color} | {color:red} Patch causes 64 errors with Hadoop v2.4.0. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m 11s {color} | {color:red} Patch causes 64 errors with Hadoop v2.4.1. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m 47s {color} | {color:red} Patch causes 64 errors with Hadoop v2.5.0. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m 23s {color} | {color:red} Patch causes 64 errors with Hadoop v2.5.1. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m 59s {color} | {color:red} Patch causes 64 errors with Hadoop v2.5.2. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m 36s {color} | {color:red} Patch causes 64 errors with Hadoop v2.6.1. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m 12s {color} | {color:red} Patch causes 64 errors with Hadoop v2.6.2. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m 48s {color} | {color:red} Patch causes 64 errors with Hadoop v2.6.3. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m 24s {color} | {color:red} Patch causes 64 errors with Hadoop v2.7.1. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 12s {color} | {color:red} hbase-client in the patch failed. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 50s {color} | {color:green} the patch passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 36s {color} | {color:green} the patch passed with JDK v1.7.0_79 {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 46s {color} | {color:green} hbase-common in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 17s {color} | {color:red} hbase-client in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s {color} | {color:green} Patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 23m 12s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12807892/HBASE-15174_3.patch | | JIRA Issue | HBASE-15174 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 72d3f2a | | Default Java | 1.7.0_79 | | Multi-JDK versions | /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79 | | findbugs | v3.0.0 | | mvninstall | https://builds.apache.org/job/PreCommit-HBASE-Build/2098/artifact/patchprocess/patch-mvninstall-hbase-client.txt | | compile | https://builds.apache.org/job/PreCommit-HBASE-Build/2098/artifact/patchprocess/patch-compile-hbase-client-jdk1.7.0_79.txt | | javac | https://builds.apache.org/job/PreCommit-HBASE-Build/2098/artifact/patchprocess/patch-compile-hbase-client-jdk1.7.0_79.txt | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/2098/artifact/patchprocess/patch-findbugs-hbase-client.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/2098/artifact/patchprocess/patch-unit-hbase-client.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/2098/testReport/ | | modules | C: hbase-common hbase-client U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/2098/console | | Powered by | Apache Yetus 0.2.1 http://yetus.apache.org | This message was automatically generated. > Client Public API should not have PB objects in 2.0 > --------------------------------------------------- > > Key: HBASE-15174 > URL: https://issues.apache.org/jira/browse/HBASE-15174 > Project: HBase > Issue Type: Sub-task > Reporter: Enis Soztutar > Assignee: ramkrishna.s.vasudevan > Priority: Blocker > Fix For: 2.0.0 > > Attachments: HBASE-15174.patch, HBASE-15174_1.patch, > HBASE-15174_2.patch, HBASE-15174_3.patch > > > Some more cleanup for the parent jira. > We have leaked some PB structs in Admin (and possible other places). > We should clean up these API before 2.0. > Examples include: > {code} > AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final > TableName tableName) > throws IOException; > > .... > void snapshot(final String snapshotName, > final TableName tableName, > HBaseProtos.SnapshotDescription.Type type) throws IOException, > SnapshotCreationException, > IllegalArgumentException; > .... > MasterProtos.SnapshotResponse > takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot) > throws IOException, SnapshotCreationException; > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)