[ https://issues.apache.org/jira/browse/HBASE-15959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15319890#comment-15319890 ]
Jingcheng Du commented on HBASE-15959: -------------------------------------- bq. In second compaction, scanner has 10 storefiles. Shouldn't there be 6? 5 from recent flushes and 1 from earlier compaction. Probably because mob cleaner doesn't clean old hfiles. Does this needs fixing? region.compact doesn't compact mob files, I think this is not related with cleaners. I read the test, I guess this issue is because the scanner is not closed in the second scan. And the compactor cannot find the cells later than the smallest read point? {code} scanner = table.getScanner(scan); scanner.next(100); numScanNext++; + scanner.close(); {code} > Fix flaky test TestRegionServerMetrics.testMobMetrics > ----------------------------------------------------- > > Key: HBASE-15959 > URL: https://issues.apache.org/jira/browse/HBASE-15959 > Project: HBase > Issue Type: Bug > Reporter: Appy > Assignee: huaxiang sun > > It flakes > [here|https://github.com/apache/hbase/blob/b557f0bec62a48753e5d01d7a47f3c9e5a6b3ee8/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java#L460]. > There are two weird things i identified: > 1. In second compaction, > [scanner|https://github.com/apache/hbase/blob/b557f0bec62a48753e5d01d7a47f3c9e5a6b3ee8/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java#L173] > has 10 storefiles. Shouldn't there be 6? 5 from recent flushes and 1 from > earlier compaction. Probably because mob cleaner doesn't clean old hfiles. > Does this needs fixing? > 2. Across runs, same cell (ie. same key) may or may not be considered mob > reference cell. > [here|https://github.com/apache/hbase/blob/b557f0bec62a48753e5d01d7a47f3c9e5a6b3ee8/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java#L213]. > This at least happens with row keys 0 - 4 (which got compacted earlier). > [~jmhsieh] Any ideas why this would happen. -- This message was sent by Atlassian JIRA (v6.3.4#6332)