[ 
https://issues.apache.org/jira/browse/HBASE-15959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15320048#comment-15320048
 ] 

huaxiang sun commented on HBASE-15959:
--------------------------------------

The old store files are not archived right after compaction, 
compaction.discharger does that periodically. After the first major compaction, 
there are 6 store files, 5 smaller ones, one with everything. Since 
compaction.discharger does not kick in yet, at that time, region.initialize() 
will open these files again, I think at that time, it messed up, some cells are 
from the old hfile which has mob reference, some from the final one, which does 
not have the reference cell. I will upload a patch shortly, thanks.

> Fix flaky test TestRegionServerMetrics.testMobMetrics
> -----------------------------------------------------
>
>                 Key: HBASE-15959
>                 URL: https://issues.apache.org/jira/browse/HBASE-15959
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Appy
>            Assignee: huaxiang sun
>
> It flakes 
> [here|https://github.com/apache/hbase/blob/b557f0bec62a48753e5d01d7a47f3c9e5a6b3ee8/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java#L460].
> There are two weird things i identified:
> 1. In second compaction, 
> [scanner|https://github.com/apache/hbase/blob/b557f0bec62a48753e5d01d7a47f3c9e5a6b3ee8/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java#L173]
>  has 10 storefiles. Shouldn't there be 6? 5 from recent flushes and 1 from 
> earlier compaction. Probably because mob cleaner doesn't clean old hfiles. 
> Does this needs fixing?
> 2. Across runs, same cell (ie. same key) may or may not be considered mob 
> reference cell. 
> [here|https://github.com/apache/hbase/blob/b557f0bec62a48753e5d01d7a47f3c9e5a6b3ee8/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java#L213].
>  This at least happens with row keys 0 - 4 (which got compacted earlier). 
> [~jmhsieh] Any ideas why this would happen.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to