[
https://issues.apache.org/jira/browse/HBASE-15584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323450#comment-15323450
]
Romil Choksi commented on HBASE-15584:
--------------------------------------
[~tedyu]
I tried the list_procedures command while I had a couple of full backups in
progress.
{code}
hbase(main):008:0> list_procedures
Id Name State Start_Time Last_Update
1 CreateTableProcedure (table=hbase:backup) ROLLEDBACK Wed Jun 08 23:42:00 UTC
2016 Wed Jun 08 23:42:00 UTC 2016
36 FullTableBackupProcedure
(targetRootDir=hdfs://hbase-test-secure-rc-7:8020/user/hbase) RUNNABLE Thu Jun
09 21:20:44 UTC 2016 Thu Jun 09 21:20:46 UTC 2016
37 FullTableBackupProcedure
(targetRootDir=hdfs://hbase-test-secure-rc-7:8020/user/hbase) RUNNABLE Thu Jun
09 21:20:46 UTC 2016 Thu Jun 09 21:20:46 UTC 2016
3 row(s) in 0.0240 seconds
{code}
Now just looking at the list_procedures output, I am not sure which procId
belongs to which backup process. I can probably take a look at the hbase backup
history, and compare the timestamps. Or go through the logs to get the
necessary details. In such cases, I think it will be better for the user to
have cancel option that takes in backupId and doesn't have to deal with
figuring out the procId.
> Revisit handling of BackupState#CANCELLED
> -----------------------------------------
>
> Key: HBASE-15584
> URL: https://issues.apache.org/jira/browse/HBASE-15584
> Project: HBase
> Issue Type: Sub-task
> Reporter: Ted Yu
> Priority: Minor
>
> During review of HBASE-15411, Enis made the following point:
> {code}
> nobody puts the backup in cancelled state. setCancelled() is not used. So if
> I abort a backup, who writes to the system table the new state?
> Not sure whether this is a phase 1 patch issue or due to this patch. We can
> open a new jira and address it there if you do not want to do it in this
> patch.
> Also maybe this should be named ABORTED rather than CANCELLED.
> {code}
> This issue is to decide whether this state should be kept (e.g. through
> notification from procedure V2 framework in response to abortion).
> If it is to be kept, the state should be renamed ABORTED.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
