[
https://issues.apache.org/jira/browse/HBASE-15584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15324802#comment-15324802
]
Stephen Yuan Jiang commented on HBASE-15584:
--------------------------------------------
[~tedyu], current code in {{FullTableBackupProcedure#toStringClassDetails}}
only contains backup root directory, you can add more information there (eg.
such as backupId; or list of tables that backup is running).
{code}
@Override
public void toStringClassDetails(StringBuilder sb) {
sb.append(getClass().getSimpleName());
sb.append(" (targetRootDir=");
sb.append(targetRootDir);
sb.append(")");
{code}
> Revisit handling of BackupState#CANCELLED
> -----------------------------------------
>
> Key: HBASE-15584
> URL: https://issues.apache.org/jira/browse/HBASE-15584
> Project: HBase
> Issue Type: Sub-task
> Reporter: Ted Yu
> Priority: Minor
>
> During review of HBASE-15411, Enis made the following point:
> {code}
> nobody puts the backup in cancelled state. setCancelled() is not used. So if
> I abort a backup, who writes to the system table the new state?
> Not sure whether this is a phase 1 patch issue or due to this patch. We can
> open a new jira and address it there if you do not want to do it in this
> patch.
> Also maybe this should be named ABORTED rather than CANCELLED.
> {code}
> This issue is to decide whether this state should be kept (e.g. through
> notification from procedure V2 framework in response to abortion).
> If it is to be kept, the state should be renamed ABORTED.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
