[ 
https://issues.apache.org/jira/browse/HBASE-14743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15335094#comment-15335094
 ] 

stack commented on HBASE-14743:
-------------------------------

[~reidchan] I tried it. Looks good in visualvm (see attached). Maybe call it 
Memory rather the Heap Memory unless there is something that might preclude our 
adding offheap metrics down the road? Does it work for you [~reidchan]? I tried 
loading stuff and reading but the metrics didn't change... 

> Add metrics around HeapMemoryManager
> ------------------------------------
>
>                 Key: HBASE-14743
>                 URL: https://issues.apache.org/jira/browse/HBASE-14743
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Elliott Clark
>            Assignee: Reid Chan
>            Priority: Minor
>         Attachments: HBASE-14743.001.patch, HBASE-14743.002.patch, 
> HBASE-14743.003.patch, HBASE-14743.004.patch, HBASE-14743.005.patch, 
> HBASE-14743.006.patch, HBASE-14743.007.patch, HBASE-14743.008.patch, 
> HBASE-14743.009.patch, HBASE-14743.009.v2.patch, Screen Shot 2016-06-16 at 
> 5.39.13 PM.png
>
>
> it would be good to know how many invocations there have been.
> How many decided to expand memstore.
> How many decided to expand block cache.
> How many decided to do nothing.
> etc.
> When that's done use those metrics to clean up the tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to