[
https://issues.apache.org/jira/browse/HBASE-14743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337283#comment-15337283
]
Appy commented on HBASE-14743:
------------------------------
[~stack] , i think Reid was trying to state that the tuner itself works only
when those conditions are satisfied. So if the tuner itself is not on, the
metrics will of course be 0.
Code pointers:
- HeapMemoryTuner chore is always started but it registers to memstore flusher
only when {{tunerOn}} is true
([here|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemoryManager.java#L194]).
- Whether tuner should be turned on is decided in
[doInit|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemoryManager.java#L113]
based on conditions which Reid mentioned earlier.
> Add metrics around HeapMemoryManager
> ------------------------------------
>
> Key: HBASE-14743
> URL: https://issues.apache.org/jira/browse/HBASE-14743
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Reid Chan
> Priority: Minor
> Attachments: HBASE-14743.001.patch, HBASE-14743.002.patch,
> HBASE-14743.003.patch, HBASE-14743.004.patch, HBASE-14743.005.patch,
> HBASE-14743.006.patch, HBASE-14743.007.patch, HBASE-14743.008.patch,
> HBASE-14743.009.patch, HBASE-14743.009.rw3.patch, HBASE-14743.009.v2.patch,
> Screen Shot 2016-06-16 at 5.39.13 PM.png
>
>
> it would be good to know how many invocations there have been.
> How many decided to expand memstore.
> How many decided to expand block cache.
> How many decided to do nothing.
> etc.
> When that's done use those metrics to clean up the tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
