[
https://issues.apache.org/jira/browse/HBASE-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155383#comment-13155383
]
stack commented on HBASE-4308:
------------------------------
So, we are moving the call of regionOnline out of OpenRegionHandler and up as a
reaction to the delete of znode in AM? That looks like a good change.
What is odd though is that the log message -- "Node deleted but still in RIT: "
-- gives the impression that there is something wrong when this log message
comes out though this is now the legit way of onlining a region in master. I'd
suggest that we change the log message to 'Node deleted ...'.
Should this test which is in makeRegionOnline be up in the caller (You test
SPLIT and SPLITTING in caller... it would make code easier to read):
{code}
if (rs.getState().equals(RegionState.State.OPEN))
{code}
Why don't we do rs.isOpened() instead of the above check?
Call the method makeRegionOnline instead regionOnline?
This log message seems extraneous given the above logging of delete:
{code}
+ debugLog(regionInfo, "The znode of region "
+ + regionInfo.getRegionNameAsString() + " has been deleted.");
{code}
Otherwise patch looks good.
> Race between RegionOpenedHandler and AssignmentManager
> ------------------------------------------------------
>
> Key: HBASE-4308
> URL: https://issues.apache.org/jira/browse/HBASE-4308
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.92.0
>
> Attachments: HBASE-4308.patch, HBASE-4308_1.patch
>
>
> When the master is processing a ZK event for REGION_OPENED, it calls delete()
> on the znode before it removes the node from RegionsInTransition. If the
> notification of that delete comes back into AssignmentManager before the
> region is removed from RIT, you see an error like:
> 2011-08-30 17:43:29,537 WARN [main-EventThread]
> master.AssignmentManager(861): Node deleted but still in RIT:
> .META.,,1.1028785192 state=OPEN, ts=1314751409532,
> server=todd-w510,55655,1314751396840
> Not certain if it causes issues, but it's a concerning log message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
