[
https://issues.apache.org/jira/browse/HBASE-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155792#comment-13155792
]
ramkrishna.s.vasudevan commented on HBASE-4308:
-----------------------------------------------
@Stack
Thanks for your review
{code}
+ private void makeRegionOnline(RegionState rs, HRegionInfo regionInfo) {
+ regionOnline(regionInfo, rs.serverName);
+ LOG.info("The master has opened the region "
+ + regionInfo.getRegionNameAsString() + " that was online on "
+ + rs.serverName);
+ if (this.getZKTable().isDisablingOrDisabledTable(
+ regionInfo.getTableNameAsString())) {
+ debugLog(regionInfo, "Opened region "
+ + regionInfo.getRegionNameAsString() + " but "
+ + "this table is disabled, triggering close of region");
+ unassign(regionInfo);
+ }
+ }
{code}
I have not broken the logic of unassign if the table is disabled. In
OpenedRegionHandler also the same code is present even if deletion of the node
fails.
Same way if it the callback comes on successful deletion even there this code
is present. Is it ok Stack? I will commit after your confirmation :)
> Race between RegionOpenedHandler and AssignmentManager
> ------------------------------------------------------
>
> Key: HBASE-4308
> URL: https://issues.apache.org/jira/browse/HBASE-4308
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.92.0
>
> Attachments: HBASE-4308.patch, HBASE-4308_1.patch, HBASE-4308_2.patch
>
>
> When the master is processing a ZK event for REGION_OPENED, it calls delete()
> on the znode before it removes the node from RegionsInTransition. If the
> notification of that delete comes back into AssignmentManager before the
> region is removed from RIT, you see an error like:
> 2011-08-30 17:43:29,537 WARN [main-EventThread]
> master.AssignmentManager(861): Node deleted but still in RIT:
> .META.,,1.1028785192 state=OPEN, ts=1314751409532,
> server=todd-w510,55655,1314751396840
> Not certain if it causes issues, but it's a concerning log message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
