[
https://issues.apache.org/jira/browse/HBASE-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15345281#comment-15345281
]
Appy commented on HBASE-16078:
------------------------------
I like the patch but i have few concerns on the overall idea. Sorry for not
being to able to comment on HBASE-16044 earlier. Here are my concerns:
- Why is this tool better than shell commands we already have?
- I believe it'll confuse the users, because they'll have two ways to operate
balancer (this tool and shell commands), without knowing what's the difference
i.e. if there is one.
- I believe the root cause in HABSE-16044 is, the script which broke relies on
specific formatting of command's output which is allowed to change across
minor/major versions.
In fact, the tool in this patch is basically doing the same thing, i.e. dumping
out output using {{System.out.print}} which is then parsed in graceful_stop.sh.
I don't see any difference (except that this is in java and the shell commands
are in jruby :-)).
We can't guarantee that we'll never change this tools output, because it's no
different than saying that we'll never change the shell command's output.
Bottom line, anything this tool achieves, can be achieve with shell command.
And if not, we should likely rethink on shell side to avoid making a line of
tools which are duplicate of shell functionality.
> Create java cli tool for managing balancer states for scripts usage
> -------------------------------------------------------------------
>
> Key: HBASE-16078
> URL: https://issues.apache.org/jira/browse/HBASE-16078
> Project: HBase
> Issue Type: Improvement
> Components: scripts, util
> Affects Versions: 2.0.0
> Reporter: Samir Ahmic
> Assignee: Samir Ahmic
> Fix For: 2.0.0
>
> Attachments: HBASE-16078_v1.patch
>
>
> This ticket is result of discussion in
> [HBASE16044|https://issues.apache.org/jira/browse/HBASE-16044] to avoid
> "hbase shell" output parsing hacks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
