[ 
https://issues.apache.org/jira/browse/HBASE-16143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15354706#comment-15354706
 ] 

ramkrishna.s.vasudevan commented on HBASE-16143:
------------------------------------------------

Thanks for the quick review.
bq.Call it getScanners() No need to say data structure name in method name
I could see that there is already a getScanners() API and getListOfScanners() 
is also something similar.
bq.Make the type as List and new ArrayList? Dont think we need a LinkedList 
anyway.
Lets see. May be yes.
I think we could do more clean up in SegmentScanner. Will do in this patch only 
then.

> Change MemstoreScanner constructor to accept List<KeyValueScanner>
> ------------------------------------------------------------------
>
>                 Key: HBASE-16143
>                 URL: https://issues.apache.org/jira/browse/HBASE-16143
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16143.patch
>
>
> A minor change that helps in creating a memstore that avoids the compaction 
> process and just allows to creates a pipeline of segments and on flush 
> directly reads the segments in the pipeline and flushes it out after creating 
> a snapshot of the pipeline. Based on test results and updated patch on 
> HBASE-14921 (to be provided) will see how much flattening helps us.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to