[
https://issues.apache.org/jira/browse/HBASE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428970#comment-15428970
]
Vladimir Rodionov edited comment on HBASE-14450 at 8/19/16 10:50 PM:
---------------------------------------------------------------------
This change I did understand:
{code}
---
a/hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestBackupLogCleaner.java
+++
b/hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestBackupLogCleaner.java
@@ -95,7 +95,7 @@ public class TestBackupLogCleaner extends TestBackupBase {
// New list of wal files is greater than the previous one,
// because new wal per RS have been opened after full backup
- assertTrue(walFiles.size() < newWalFiles.size());
+ assertTrue(walFiles.size() <= newWalFiles.size());
Connection conn = ConnectionFactory.createConnection(conf1);
{code}
Basically, this breaks the whole test's logic, [~tedyu]. The rest looks good.
was (Author: vrodionov):
This change I did understand:
{code}
---
a/hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestBackupLogCleaner.java
+++
b/hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestBackupLogCleaner.java
@@ -95,7 +95,7 @@ public class TestBackupLogCleaner extends TestBackupBase {
// New list of wal files is greater than the previous one,
// because new wal per RS have been opened after full backup
- assertTrue(walFiles.size() < newWalFiles.size());
+ assertTrue(walFiles.size() <= newWalFiles.size());
Connection conn = ConnectionFactory.createConnection(conf1);
{code}
Basically, this breaks the whole test's logic, [~tedyu].
> HBase Backup/Restore Phase 3: Multiwal support
> ----------------------------------------------
>
> Key: HBASE-14450
> URL: https://issues.apache.org/jira/browse/HBASE-14450
> Project: HBase
> Issue Type: Task
> Affects Versions: 2.0.0
> Reporter: Vladimir Rodionov
> Assignee: Ted Yu
> Labels: backup
> Fix For: 2.0.0
>
> Attachments: 14450-HBASE-7912.v1.txt, 14450-branch-7912.v1.txt,
> 14450-roll.v2.txt, 14450.HBASE-7912.v1.txt, 14450.HBASE-7912.v2.txt,
> 14450.HBASE-7912.v3.txt, 14450.roll-wait.txt, 14450.v2.txt,
> org.apache.hadoop.hbase.backup.TestIncrementalBackup-output.txt,
> testIncrementalBackup-8-15.txt, testIncrementalBackup-8-18.txt,
> testIncrementalBackup-succ.txt
>
>
> We need to support multiwal configurations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
