[jira] [Commented] (HBASE-16433) Remove AsyncRpcChannel related stuffs

[Duo Zhang (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-16433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430229#comment-15430229
 ] 

Duo Zhang commented on HBASE-16433:
-----------------------------------

{quote}
          protected static final Descriptors.MethodDescriptor GET_DESCRIPTOR = 
ClientProtos.ClientService
              .getDescriptor().findMethodByName("Get");
        
          protected static final Descriptors.MethodDescriptor MUTATE_DESCRIPTOR 
= ClientProtos.ClientService
              .getDescriptor().findMethodByName("Mutate");
        
          protected static final Descriptors.MethodDescriptor MULTI_DESCRIPTOR 
= ClientProtos.ClientService
              .getDescriptor().findMethodByName("Multi");
        
          public static final Descriptors.MethodDescriptor 
EXEC_SERVICE_DESCRIPTOR = ClientProtos
              .ClientService.getDescriptor().findMethodByName("ExecService");
{quote}

I do not think this will fail at compile time if the proto file is changed. And 
also, you can call the get method with a protobuf message with any type and 
does not cause any compile error. I do not think this a good practice.

> Remove AsyncRpcChannel related stuffs
> -------------------------------------
>
>                 Key: HBASE-16433
>                 URL: https://issues.apache.org/jira/browse/HBASE-16433
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16433.patch
>
>
> AsyncRpcChannel can not be used by protobuf stub. We should implement the 
> async logic along with the RpcChannel interface of protobuf.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)