[ 
https://issues.apache.org/jira/browse/HBASE-16490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434424#comment-15434424
 ] 

Heng Chen commented on HBASE-16490:
-----------------------------------

Currently,  there is no way to pass some instance into {{FileCleanerDelegate}} 
subclasses,   i think we could add one method "init(Map<String, Object> 
params)"  into  {{FileCleanerDelegate}} ,  use it as init method after 
construction,  so we could pass any instance which is needed into subclass,  
wdyt?  [~mbertozzi]

> Fix race condition between SnapshotManager and SnapshotCleaner
> --------------------------------------------------------------
>
>                 Key: HBASE-16490
>                 URL: https://issues.apache.org/jira/browse/HBASE-16490
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Heng Chen
>             Fix For: 2.0.0
>
>
> As [~mbertozzi] comments on HBASE-16464,  there maybe race condition between 
> SnapshotManager and SnapshotCleaner.  We should use one lock when create 
> snapshot,  and cleanup should acquire the lock before take action.
> One method is pass HMaster as param into Cleaner through 
> {{FileCleanerDelegate.getDeletableFiles}},  suggestions are welcomed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to