[
https://issues.apache.org/jira/browse/HBASE-16490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435288#comment-15435288
]
Matteo Bertozzi commented on HBASE-16490:
-----------------------------------------
yeah something along this line seems good.
passing arguments to the cleaner like this seems already ok as it is to me.
but we don't want a global lock on the snapshot manager. we want a lock on the
snapshotName since each snapshot can run concurrently and the cleaner knows
which snapshot wants to remove from .tmp since the folder is .tmp/snapshotName/
> Fix race condition between SnapshotManager and SnapshotCleaner
> --------------------------------------------------------------
>
> Key: HBASE-16490
> URL: https://issues.apache.org/jira/browse/HBASE-16490
> Project: HBase
> Issue Type: Bug
> Reporter: Heng Chen
> Fix For: 2.0.0
>
> Attachments: HBASE-16490.patch
>
>
> As [~mbertozzi] comments on HBASE-16464, there maybe race condition between
> SnapshotManager and SnapshotCleaner. We should use one lock when create
> snapshot, and cleanup should acquire the lock before take action.
> One method is pass HMaster as param into Cleaner through
> {{FileCleanerDelegate.getDeletableFiles}}, suggestions are welcomed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
