[
https://issues.apache.org/jira/browse/HBASE-16471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434663#comment-15434663
]
Pankaj Kumar commented on HBASE-16471:
--------------------------------------
Thanks [~ted_yu] and [~ashish singhi] for reviewing the patch. Have addressed
white space error in V2 patch.
V2 patch can be applied in branch-1 and 1.3 as well and attached patch for 0.98
branch also.
> Region Server metrics context will be wrong when machine hostname contain
> "master" word
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-16471
> URL: https://issues.apache.org/jira/browse/HBASE-16471
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 2.0.0, 1.3.0, 0.98.21
> Reporter: Pankaj Kumar
> Assignee: Pankaj Kumar
> Priority: Minor
> Attachments: HBASE-16471-0.98.patch, HBASE-16471-V2.patch,
> HBASE-16471.patch
>
>
> While initializing RSRpcServices server name is formed as,
> {code}
> String name = rs.getProcessName() + "/" + initialIsa.toString();
> {code}
> So name will be like "regionserver/host_Name/host_IP:port".
> During MetricsHBaseServer intializing, we create server context name using
> String contains() which will be wrong when machine hostname contain "master"
> words.
> In MetricsHBaseServerSourceFactory,
> {code}
> protected static String createContextName(String serverName) {
> if (serverName.contains("HMaster") || serverName.contains("master")) {
> return "Master";
> } else if (serverName.contains("HRegion") ||
> serverName.contains("regionserver")) {
> return "RegionServer";
> }
> return "IPC";
> }
> {code}
> For example, "regionserver/node-master1-xyz/host-IP:16020"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
