[ 
https://issues.apache.org/jira/browse/HBASE-16471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434853#comment-15434853
 ] 

Hadoop QA commented on HBASE-16471:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 16s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s 
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 
13s {color} | {color:green} 0.98 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s 
{color} | {color:green} 0.98 passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 36s 
{color} | {color:green} 0.98 passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 
20s {color} | {color:green} 0.98 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
21s {color} | {color:green} 0.98 passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 38s 
{color} | {color:red} hbase-server in 0.98 has 85 extant Findbugs warnings. 
{color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 8s 
{color} | {color:red} hbase-hadoop-compat in 0.98 failed with JDK v1.8.0_101. 
{color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 22s 
{color} | {color:red} hbase-server in 0.98 failed with JDK v1.8.0_101. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 38s 
{color} | {color:green} 0.98 passed with JDK v1.7.0_101 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s 
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 
43s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s 
{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 32s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 37s 
{color} | {color:green} the patch passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 37s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 
19s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
21s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 6m 41s 
{color} | {color:red} The patch causes 11 errors with Hadoop v2.6.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 7m 43s 
{color} | {color:red} The patch causes 11 errors with Hadoop v2.6.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 8m 46s 
{color} | {color:red} The patch causes 11 errors with Hadoop v2.6.3. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 9m 49s 
{color} | {color:red} The patch causes 11 errors with Hadoop v2.7.1. {color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 0m 9s 
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 
21s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 8s 
{color} | {color:red} hbase-hadoop-compat in the patch failed with JDK 
v1.8.0_101. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 20s 
{color} | {color:red} hbase-server in the patch failed with JDK v1.8.0_101. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 37s 
{color} | {color:green} the patch passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 16s 
{color} | {color:green} hbase-hadoop-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 118m 20s 
{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
49s {color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 142m 52s {color} 
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:date2016-08-24 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12825242/HBASE-16471-0.98.patch
 |
| JIRA Issue | HBASE-16471 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  
hbaseanti  checkstyle  compile  |
| uname | Linux 56cff152b112 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed 
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/hbase.sh |
| git revision | 0.98 / aac4e09 |
| Default Java | 1.7.0_101 |
| Multi-JDK versions |  /usr/lib/jvm/java-8-oracle:1.8.0_101 
/usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 |
| findbugs | v2.0.1 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HBASE-Build/3231/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-HBASE-Build/3231/artifact/patchprocess/branch-javadoc-hbase-hadoop-compat-jdk1.8.0_101.txt
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-HBASE-Build/3231/artifact/patchprocess/branch-javadoc-hbase-server-jdk1.8.0_101.txt
 |
| hbaseprotoc | 
https://builds.apache.org/job/PreCommit-HBASE-Build/3231/artifact/patchprocess/patch-hbaseprotoc-hbase-server.txt
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-HBASE-Build/3231/artifact/patchprocess/patch-javadoc-hbase-hadoop-compat-jdk1.8.0_101.txt
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-HBASE-Build/3231/artifact/patchprocess/patch-javadoc-hbase-server-jdk1.8.0_101.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/3231/testReport/ |
| modules | C: hbase-hadoop-compat hbase-server U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/3231/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> Region Server metrics context will be wrong when machine hostname contain 
> "master" word
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-16471
>                 URL: https://issues.apache.org/jira/browse/HBASE-16471
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 2.0.0, 1.3.0, 0.98.21
>            Reporter: Pankaj Kumar
>            Assignee: Pankaj Kumar
>            Priority: Minor
>         Attachments: HBASE-16471-0.98.patch, HBASE-16471-V2.patch, 
> HBASE-16471.patch
>
>
> While initializing RSRpcServices server name is formed as,
> {code}
>     String name = rs.getProcessName() + "/" + initialIsa.toString();
> {code}
> So name will be like "regionserver/host_Name/host_IP:port".
> During MetricsHBaseServer intializing, we create server context name using 
> String contains() which will be wrong when machine hostname contain "master" 
> words.
> In MetricsHBaseServerSourceFactory, 
> {code}
>   protected static String createContextName(String serverName) {
>     if (serverName.contains("HMaster") || serverName.contains("master")) {
>       return "Master";
>     } else if (serverName.contains("HRegion") || 
> serverName.contains("regionserver")) {
>       return "RegionServer";
>     }
>     return "IPC";
>   }
> {code}
> For example, "regionserver/node-master1-xyz/host-IP:16020"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to