[
https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15451636#comment-15451636
]
binlijin commented on HBASE-16530:
----------------------------------
{quote}
Mark IA.Private for this AbstractDataBlockEncoder .
{quote}
Ok, miss it.
{quote}
Do we need this 'NoDataBlockEncoderUtil'? It is also missing IA.Private
annotation.
{quote}
I do not know where to put, so add a new class.
{quote}
Can we add a static method in
ByteBufferedDataEncoder/AbstractByteBufferedDataEncoder itself and call that
from the 3 algo implementations?
{quote}
Sorry i do not find ByteBufferedDataEncoder/AbstractByteBufferedDataEncoder.
{quote}
Some more code duplicates were there reg the tag compression and tag encoding
and decoding? I remember seeing that. May be it is corrected now in the last
commits?
{quote}
ROW_INDEX_V1 do not have tag compression now.
> Reduce DBE code duplication
> ---------------------------
>
> Key: HBASE-16530
> URL: https://issues.apache.org/jira/browse/HBASE-16530
> Project: HBase
> Issue Type: Sub-task
> Components: Performance
> Reporter: binlijin
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-16530-master_V1.patch, HBASE-16530-master_V2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
