[
https://issues.apache.org/jira/browse/HBASE-16086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15454457#comment-15454457
]
Heng Chen commented on HBASE-16086:
-----------------------------------
Thanks [~vincentpoon].
As for the patch, to be honest, i think it looks weird. WALCellFilter should
do cell filter, but it has {{public Entry filter(Entry entry) }} interface,
and putted into ChainWALEntryFilter which should be used to filter entry.
Why not just modify {{ChainWALEntryFilter}}, add one member WALCellFilter[]
cellFilters and do cell filter action in it's {{filter(Entry entry)}} method,
of course we could change the classname to be ChainWALFilter?
> TableCfWALEntryFilter and ScopeWALEntryFilter should not redundantly iterate
> over cells.
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-16086
> URL: https://issues.apache.org/jira/browse/HBASE-16086
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 2.0.0, 1.2.0, 1.3.0
> Reporter: churro morales
> Assignee: Vincent Poon
> Fix For: 2.0.0, 1.3.1
>
> Attachments: HBASE-16086.patch
>
>
> TableCfWALEntryFilter and ScopeWALEntryFilter both filter by iterating over
> cells. Since the filters are chained we do this work twice. Instead iterate
> over cells once and apply the "cell filtering" logic to these cells.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
