[
https://issues.apache.org/jira/browse/HBASE-16086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15477196#comment-15477196
]
Heng Chen commented on HBASE-16086:
-----------------------------------
Totally, the patch v2 lgtm, it reduced lots of duplicate code and made the
logic be more clear, +1 for it.
Please fix the javadoc warnings.
> TableCfWALEntryFilter and ScopeWALEntryFilter should not redundantly iterate
> over cells.
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-16086
> URL: https://issues.apache.org/jira/browse/HBASE-16086
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 2.0.0, 1.2.0, 1.3.0
> Reporter: churro morales
> Assignee: Vincent Poon
> Fix For: 2.0.0, 1.3.1
>
> Attachments: HBASE-16086.patch, HBASE-16086.v2.patch
>
>
> TableCfWALEntryFilter and ScopeWALEntryFilter both filter by iterating over
> cells. Since the filters are chained we do this work twice. Instead iterate
> over cells once and apply the "cell filtering" logic to these cells.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
