Yu Li commented on HBASE-15921:

You are right Heng, and as I mentioned, this is a simple demo to show how we're 
trying to implement the async API. I have more implementation on hand but I'd 
like to get some consensus before uploading bunch of codes, and need time to 
rebase on master code base (as known, quite some code refactor on client part 
recently) :-)

I agree and it's true during our code development that there're quite some 
logic in AP could/should be reused, but also some change/enhancement required, 
such as for batch, with callback and Netty, we don't need those many threads in 
{{AsyncRequestFutureImpl}} any more, a for loop to send all callbacks out is 
enough, etc.

IMHO, current AP is still blocking although it uses multiple threads to make 
the call in parallel, and the non-blocking/async work doesn't conflict but 
should corporate AP. Probably we should abstract some common methods out of 
current AP and it will work. Agree?

> Add first AsyncTable impl and create TableImpl based on it
> ----------------------------------------------------------
>                 Key: HBASE-15921
>                 URL: https://issues.apache.org/jira/browse/HBASE-15921
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jurriaan Mous
>            Assignee: Jurriaan Mous
>         Attachments: HBASE-15921.demo.patch, HBASE-15921.patch, 
> HBASE-15921.v1.patch
> First we create an AsyncTable interface with implementation without the Scan 
> functionality. Those will land in a separate patch since they need a refactor 
> of existing scans.
> Also added is a new TableImpl to replace HTable. It uses the AsyncTableImpl 
> internally and should be a bit faster because it does jump through less hoops 
> to do ProtoBuf transportation. This way we can run all existing tests on the 
> AsyncTableImpl to guarantee its quality.

This message was sent by Atlassian JIRA

Reply via email to