[ https://issues.apache.org/jira/browse/HBASE-16788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15554869#comment-15554869 ]
Hadoop QA commented on HBASE-16788: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 13s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 4s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 34s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 45s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 14s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 46s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 46s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 37s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 37s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 45s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 14s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s {color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 27m 55s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 12s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 59s {color} | {color:red} hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 28s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 79m 13s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 119m 42s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:hbase-server | | | Unconditional wait in org.apache.hadoop.hbase.regionserver.HStore.removeCompactedfiles(Collection, boolean) At HStore.java: At HStore.java:[line 2400] | | | Wait not in loop in org.apache.hadoop.hbase.regionserver.HStore.removeCompactedfiles(Collection, boolean) At HStore.java:org.apache.hadoop.hbase.regionserver.HStore.removeCompactedfiles(Collection, boolean) At HStore.java:[line 2400] | | Timed out junit tests | org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure | | | org.apache.hadoop.hbase.master.procedure.TestMasterProcedureSchedulerConcurrency | | | org.apache.hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12832110/HBASE-16788_1.patch | | JIRA Issue | HBASE-16788 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 8fa05032b93e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 96d34f2 | | Default Java | 1.8.0_101 | | findbugs | v3.0.0 | | whitespace | https://builds.apache.org/job/PreCommit-HBASE-Build/3873/artifact/patchprocess/whitespace-eol.txt | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/3873/artifact/patchprocess/new-findbugs-hbase-server.html | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/3873/artifact/patchprocess/patch-unit-hbase-server.txt | | unit test logs | https://builds.apache.org/job/PreCommit-HBASE-Build/3873/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/3873/testReport/ | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/3873/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > Race in compacted file deletion between HStore close() and > closeAndArchiveCompactedFiles() > ------------------------------------------------------------------------------------------ > > Key: HBASE-16788 > URL: https://issues.apache.org/jira/browse/HBASE-16788 > Project: HBase > Issue Type: Bug > Components: regionserver > Affects Versions: 1.3.0 > Reporter: Gary Helmling > Assignee: Gary Helmling > Priority: Blocker > Attachments: HBASE-16788_1.patch > > > HBASE-13082 changed the way that compacted files are archived from being done > inline on compaction completion to an async cleanup by the > CompactedHFilesDischarger chore. It looks like the changes to HStore to > support this introduced a race condition in the compacted HFile archiving. > In the following sequence, we can wind up with two separate threads trying to > archive the same HFiles, causing a regionserver abort: > # compaction completes normally and the compacted files are added to > {{compactedfiles}} in HStore's DefaultStoreFileManager > # *threadA*: CompactedHFilesDischargeHandler runs in a RS executor service, > calling closeAndArchiveCompactedFiles() > ## obtains HStore readlock > ## gets a copy of compactedfiles > ## releases readlock > # *threadB*: calls HStore.close() as part of region close > ## obtains HStore writelock > ## calls DefaultStoreFileManager.clearCompactedfiles(), getting a copy of > same compactedfiles > # *threadA*: calls HStore.removeCompactedfiles(compactedfiles) > ## archives files in {compactedfiles} in HRegionFileSystem.removeStoreFiles() > ## call HStore.clearCompactedFiles() > ## waits on write lock > # *threadB*: continues with close() > ## calls removeCompactedfiles(compactedfiles) > ## calls HRegionFIleSystem.removeStoreFiles() -> > HFileArchiver.archiveStoreFiles() > ## receives FileNotFoundException because the files have already been > archived by threadA > ## throws IOException > # RS aborts > I think the combination of fetching the compactedfiles list and removing the > files needs to be covered by locking. Options I see are: > * Modify HStore.closeAndArchiveCompactedFiles(): use writelock instead of > readlock and move the call to removeCompactedfiles() inside the lock. This > means the read operations will be blocked while the files are being archived, > which is bad. > * Synchronize closeAndArchiveCompactedFiles() and modify close() to call it > instead of calling removeCompactedfiles() directly > * Add a separate lock for compacted files removal and use in > closeAndArchiveCompactedFiles() and close() -- This message was sent by Atlassian JIRA (v6.3.4#6332)