[
https://issues.apache.org/jira/browse/HBASE-16821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574327#comment-15574327
]
Ashish Singhi commented on HBASE-16821:
---------------------------------------
{code}
private Pair<Multimap<ByteBuffer, LoadQueueItem>, List<String>>
groupOrSplitPhase(
{code}
Update the javadoc for this method.
{code}
protected Pair<List<LoadQueueItem>, String> groupOrSplit(
{code}
You are changing the return type of protected api in a public audience class,
is this ok ? Why not add another method instead and keep the existing as it is.
{code}
public List<String> run(String dirPath, Map<byte[], List<Path>> map, TableName
tableName)
{code}
Let it return int only like the other run api, you can move the below logic
here.
{code}
List<String> missing = run(dirPath, null, tableName);
if (missing == null) return 0;
return -1;
{code}
Suggest to have a better variable name than missing, may be missingHFiles or
something else.
> Enhance LoadIncrementalHFiles to convey missing hfiles if any
> -------------------------------------------------------------
>
> Key: HBASE-16821
> URL: https://issues.apache.org/jira/browse/HBASE-16821
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 16821.v1.txt
>
>
> When map parameter of run() method is not null:
> {code}
> public int run(String dirPath, Map<byte[], List<Path>> map, TableName
> tableName) throws Exception{
> {code}
> the caller knows the exact files to be bulk loaded.
> This issue is to enhance the run() API so that when certain hfiles turn out
> to be missing, the return value should indicate the missing files.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
