Ashish Singhi commented on HBASE-16821:

private Pair<Multimap<ByteBuffer, LoadQueueItem>, List<String>> 
Update the javadoc for this method.

protected Pair<List<LoadQueueItem>, String> groupOrSplit(
You are changing the return type of protected api in a public audience class, 
is this ok ? Why not add another method instead and keep the existing as it is.

public List<String> run(String dirPath, Map<byte[], List<Path>> map, TableName 
Let it return int only like the other run api, you can move the below logic 
List<String> missing = run(dirPath, null, tableName);
if (missing == null) return 0;
return -1;

Suggest to have a better variable name than missing, may be missingHFiles or 
something else.

> Enhance LoadIncrementalHFiles to convey missing hfiles if any
> -------------------------------------------------------------
>                 Key: HBASE-16821
>                 URL: https://issues.apache.org/jira/browse/HBASE-16821
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 16821.v1.txt
> When map parameter of run() method is not null:
> {code}
>   public int run(String dirPath, Map<byte[], List<Path>> map, TableName 
> tableName) throws Exception{
> {code}
> the caller knows the exact files to be bulk loaded.
> This issue is to enhance the run() API so that when certain hfiles turn out 
> to be missing, the return value should indicate the missing files.

This message was sent by Atlassian JIRA

Reply via email to