Ted Yu commented on HBASE-16821:

For groupOrSplit(), it is the last of calls (lowest level) where 
FileNotFoundException detection is placed.
If another method is added, parameter list must be different. API would look 
It is protected, not public. It should be fine to do the refactor.

bq. public List<String> run(String dirPath, Map<byte[], List<Path>> map, 
TableName tableName)

The above is not in branch-1. Meaning it is new public method. We can change 
its return type.

bq. you can move the below logic here.

Can you clarify ?
The new run method needs to return missing hfiles.

> Enhance LoadIncrementalHFiles to convey missing hfiles if any
> -------------------------------------------------------------
>                 Key: HBASE-16821
>                 URL: https://issues.apache.org/jira/browse/HBASE-16821
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 16821.v1.txt
> When map parameter of run() method is not null:
> {code}
>   public int run(String dirPath, Map<byte[], List<Path>> map, TableName 
> tableName) throws Exception{
> {code}
> the caller knows the exact files to be bulk loaded.
> This issue is to enhance the run() API so that when certain hfiles turn out 
> to be missing, the return value should indicate the missing files.

This message was sent by Atlassian JIRA

Reply via email to