[
https://issues.apache.org/jira/browse/HBASE-16799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15576317#comment-15576317
]
Hudson commented on HBASE-16799:
--------------------------------
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #1786 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/1786/])
HBASE-16799 CP exposed Store should not expose unwanted APIs. (anoopsamjohn:
rev 5f75fa0c4f660939d5eea10e3f5418386e90cea1)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestWalAndCompactingMemStoreFlush.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestWALReplay.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/FlushNonSloppyStoresFirstPolicy.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultMemStore.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HMobStore.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestIOFencing.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
> CP exposed Store should not expose unwanted APIs
> -------------------------------------------------
>
> Key: HBASE-16799
> URL: https://issues.apache.org/jira/browse/HBASE-16799
> Project: HBase
> Issue Type: Sub-task
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Fix For: 2.0.0
>
> Attachments: HBASE-16799.patch, HBASE-16799.patch,
> HBASE-16799_V2.patch, HBASE-16799_V3.patch, HBASE-16799_V4.patch
>
>
> Store is exposed to CPs. The main use cases I can think of are getting store
> scanner and other getters which return different states like memstore size,
> max seqId etc. Those make sense.
> But we added many other APIs which changes the state of the memstore, bulk
> load files etc into this interface. Even an API which expose the memstore
> itself!. This allow adding mutations into memstore bypassing all steps in
> region. We track the memstore size per region level as well as globally.
> These only allow us to flush region at sizes and/or flush selected regions
> because of global heap pressure. Now if a CP get hold of store and/or
> memstore, it can add mutations with out knowledge of these size accounting
> and possibly OOME the RS. Similar way the bulk load related APIs. At HRegion
> level, there are steps done (WAL write etc) after the bulk load HFile on
> store. So bypassing these wont be correct.
> In this jira, plan is to remove all such leaked APIs from Store. They are
> called from HRegion and we can type cast to HStore to call them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
