[ 
https://issues.apache.org/jira/browse/HBASE-15532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15587776#comment-15587776
 ] 

Hadoop QA commented on HBASE-15532:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 16s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} rubocop {color} | {color:blue} 0m 0s 
{color} | {color:blue} rubocop was not available. {color} |
| {color:blue}0{color} | {color:blue} ruby-lint {color} | {color:blue} 0m 0s 
{color} | {color:blue} Ruby-lint was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 13 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 36s 
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 
41s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 35s 
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 
27s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 
16s {color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 5s 
{color} | {color:red} hbase-protocol-shaded in master has 22 extant Findbugs 
warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 0s 
{color} | {color:red} hbase-server in master has 1 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 41s 
{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s 
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 
57s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 37s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 2m 37s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 37s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 
28s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 
12s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s 
{color} | {color:red} The patch has 90 line(s) that end in whitespace. Use git 
apply --whitespace=fix. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 3s 
{color} | {color:red} The patch 6 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s 
{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
33m 51s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1 or 3.0.0-alpha1. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 4s 
{color} | {color:red} hbase-server generated 19 new + 1 unchanged - 0 fixed = 
20 total (was 1) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 31s 
{color} | {color:red} hbase-server generated 1 new + 1 unchanged - 0 fixed = 2 
total (was 1) {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 46s 
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 19s 
{color} | {color:green} hbase-protocol in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 32s 
{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 1s 
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 99m 37s {color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 24s 
{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m 35s 
{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m 
31s {color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 187m 11s {color} 
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-server |
|  |  org.apache.hadoop.hbase.StartcodeAgnosticServerName overrides equals in 
ServerName and may not be symmetric  At StartcodeAgnosticServerName.java:and 
may not be symmetric  At StartcodeAgnosticServerName.java:[lines 56-59] |
|  |  
org.apache.hadoop.hbase.favored.FavoredNodesManager.generateFavoredNodes(FavoredNodeAssignmentHelper,
 Map, List, List) makes inefficient use of keySet iterator instead of entrySet 
iterator  At FavoredNodesManager.java:inefficient use of keySet iterator 
instead of entrySet iterator  At FavoredNodesManager.java:[line 97] |
|  |  
org.apache.hadoop.hbase.favored.FavoredNodesManager.removeFavoredNode(ServerName,
 List) makes inefficient use of keySet iterator instead of entrySet iterator  
At FavoredNodesManager.java:of keySet iterator instead of entrySet iterator  At 
FavoredNodesManager.java:[line 239] |
|  |  
org.apache.hadoop.hbase.master.MasterRpcServices.redistributeFavoredNodes() 
makes inefficient use of keySet iterator instead of entrySet iterator  At 
MasterRpcServices.java:keySet iterator instead of entrySet iterator  At 
MasterRpcServices.java:[line 1680] |
|  |  Possible null pointer dereference of admin in 
org.apache.hadoop.hbase.master.ServerManager.sendFavoredNodes(ServerName, Map)  
Dereferenced at ServerManager.java:admin in 
org.apache.hadoop.hbase.master.ServerManager.sendFavoredNodes(ServerName, Map)  
Dereferenced at ServerManager.java:[line 1225] |
|  |  Load of known null value in 
org.apache.hadoop.hbase.master.balancer.FavoredNodeAssignmentHelper.multiRackCase(HRegionInfo,
 ServerName, String)  At FavoredNodeAssignmentHelper.java:in 
org.apache.hadoop.hbase.master.balancer.FavoredNodeAssignmentHelper.multiRackCase(HRegionInfo,
 ServerName, String)  At FavoredNodeAssignmentHelper.java:[line 568] |
|  |  Possible null pointer dereference of randomServer in 
org.apache.hadoop.hbase.master.balancer.FavoredNodeAssignmentHelper.getOneRandomServer(String,
 Set)  Dereferenced at FavoredNodeAssignmentHelper.java:randomServer in 
org.apache.hadoop.hbase.master.balancer.FavoredNodeAssignmentHelper.getOneRandomServer(String,
 Set)  Dereferenced at FavoredNodeAssignmentHelper.java:[line 629] |
|  |  
org.apache.hadoop.hbase.master.balancer.FavoredNodeAssignmentHelper.generateFavoredNodes(Map)
 makes inefficient use of keySet iterator instead of entrySet iterator  At 
FavoredNodeAssignmentHelper.java:keySet iterator instead of entrySet iterator  
At FavoredNodeAssignmentHelper.java:[line 860] |
|  |  
org.apache.hadoop.hbase.master.balancer.FavoredNodeAssignmentHelper.generateRRSecondaryAndTertiary(Map,
 String) makes inefficient use of keySet iterator instead of entrySet iterator  
At FavoredNodeAssignmentHelper.java:of keySet iterator instead of entrySet 
iterator  At FavoredNodeAssignmentHelper.java:[line 822] |
|  |  Inconsistent synchronization of 
org.apache.hadoop.hbase.master.balancer.FavoredNodeLoadBalancer.conf; locked 
50% of time  Unsynchronized access at FavoredNodeLoadBalancer.java:50% of time  
Unsynchronized access at FavoredNodeLoadBalancer.java:[line 79] |
|  |  Inconsistent synchronization of 
org.apache.hadoop.hbase.master.balancer.FavoredNodeLoadBalancer.primaryRSToRegionMap;
 locked 90% of time  Unsynchronized access at FavoredNodeLoadBalancer.java:90% 
of time  Unsynchronized access at FavoredNodeLoadBalancer.java:[line 383] |
|  |  Inconsistent synchronization of 
org.apache.hadoop.hbase.master.balancer.FavoredNodeLoadBalancer.secondaryRSToRegionMap;
 locked 90% of time  Unsynchronized access at FavoredNodeLoadBalancer.java:90% 
of time  Unsynchronized access at FavoredNodeLoadBalancer.java:[line 384] |
|  |  Inconsistent synchronization of 
org.apache.hadoop.hbase.master.balancer.FavoredNodeLoadBalancer.teritiaryRSToRegionMap;
 locked 90% of time  Unsynchronized access at FavoredNodeLoadBalancer.java:90% 
of time  Unsynchronized access at FavoredNodeLoadBalancer.java:[line 385] |
|  |  
org.apache.hadoop.hbase.master.balancer.FavoredNodeLoadBalancer.generateFavoredNodes(FavoredNodeAssignmentHelper,
 Map, List, List) makes inefficient use of keySet iterator instead of entrySet 
iterator  At FavoredNodeLoadBalancer.java:inefficient use of keySet iterator 
instead of entrySet iterator  At FavoredNodeLoadBalancer.java:[line 357] |
|  |  
org.apache.hadoop.hbase.master.balancer.FavoredNodeLoadBalancer.removeFavoredNode(ServerName,
 List) makes inefficient use of keySet iterator instead of entrySet iterator  
At FavoredNodeLoadBalancer.java:of keySet iterator instead of entrySet iterator 
 At FavoredNodeLoadBalancer.java:[line 505] |
|  |  Exception is caught when Exception is not thrown in 
org.apache.hadoop.hbase.master.balancer.FavoredStochasticBalancer.retainAssignment(Map,
 List)  At FavoredStochasticBalancer.java:is not thrown in 
org.apache.hadoop.hbase.master.balancer.FavoredStochasticBalancer.retainAssignment(Map,
 List)  At FavoredStochasticBalancer.java:[line 319] |
|  |  
org.apache.hadoop.hbase.master.balancer.FavoredStochasticBalancer.completeRedistribute(Map)
 makes inefficient use of keySet iterator instead of entrySet iterator  At 
FavoredStochasticBalancer.java:keySet iterator instead of entrySet iterator  At 
FavoredStochasticBalancer.java:[line 432] |
|  |  
org.apache.hadoop.hbase.master.balancer.FavoredStochasticBalancer.retainAssignment(Map,
 List) makes inefficient use of keySet iterator instead of entrySet iterator  
At FavoredStochasticBalancer.java:of keySet iterator instead of entrySet 
iterator  At FavoredStochasticBalancer.java:[line 309] |
|  |  
org.apache.hadoop.hbase.master.balancer.FavoredStochasticBalancer.roundRobinAssignment(List,
 List) makes inefficient use of keySet iterator instead of entrySet iterator  
At FavoredStochasticBalancer.java:of keySet iterator instead of entrySet 
iterator  At FavoredStochasticBalancer.java:[line 129] |
| Failed junit tests | hadoop.hbase.regionserver.TestRegionFavoredNodes |
|   | hadoop.hbase.master.balancer.TestFavoredStochasticLoadBalancer |
|   | hadoop.hbase.master.balancer.TestFavoredStochasticBalancerPickers |
|   | hadoop.hbase.master.TestRegionPlacement2 |
| Timed out junit tests | org.apache.hadoop.hbase.client.TestFromClientSide |
|   | org.apache.hadoop.hbase.client.TestHCM |
|   | 
org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClientWithRegionReplicas |
|   | org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClient |
|   | org.apache.hadoop.hbase.client.TestMobSnapshotCloneIndependence |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12834087/HBASE-15532.master.001.patch
 |
| JIRA Issue | HBASE-15532 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  
hbaseanti  checkstyle  compile  cc  hbaseprotoc  xml  rubocop  ruby_lint  |
| uname | Linux 4ca98eb8486c 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 
20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / ef8c65e |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HBASE-Build/4094/artifact/patchprocess/branch-findbugs-hbase-protocol-shaded-warnings.html
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HBASE-Build/4094/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
 |
| whitespace | 
https://builds.apache.org/job/PreCommit-HBASE-Build/4094/artifact/patchprocess/whitespace-eol.txt
 |
| whitespace | 
https://builds.apache.org/job/PreCommit-HBASE-Build/4094/artifact/patchprocess/whitespace-tabs.txt
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HBASE-Build/4094/artifact/patchprocess/new-findbugs-hbase-server.html
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-HBASE-Build/4094/artifact/patchprocess/diff-javadoc-javadoc-hbase-server.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/4094/artifact/patchprocess/patch-unit-hbase-server.txt
 |
| unit test logs |  
https://builds.apache.org/job/PreCommit-HBASE-Build/4094/artifact/patchprocess/patch-unit-hbase-server.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/4094/testReport/ |
| modules | C: hbase-common hbase-protocol hbase-protocol-shaded hbase-client 
hbase-server hbase-rsgroup hbase-shell U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/4094/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> core favored nodes enhancements
> -------------------------------
>
>                 Key: HBASE-15532
>                 URL: https://issues.apache.org/jira/browse/HBASE-15532
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Francis Liu
>            Assignee: Thiruvel Thirumoolan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15532.master.000.patch, 
> HBASE-15532.master.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to