[
https://issues.apache.org/jira/browse/HBASE-16960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615010#comment-15615010
]
Anoop Sam John commented on HBASE-16960:
----------------------------------------
Below some lines we have this
{code}
// We may have picked up an exception above trying to offer sync
if (this.exception != null) {
cleanupOutstandingSyncsOnException(sequence, this.exception
instanceof DamagedWALException
? this.exception : new DamagedWALException("On sync",
this.exception));
}
{code}
Why it did not happen is we have return in catch block
{code}
catch (Exception e) {
// Failed append. Record the exception.
this.exception = e;
// Return to keep processing events coming off the ringbuffer
return;
}
{code}
So this exception not null check was/is intended to check for the case of
{code}
catch (Exception e) {
// Should NEVER get here.
requestLogRoll();
this.exception = new DamagedWALException("Failed offering sync", e);
}
{code}
Only?
I dont know in depth abt the code here. Just asking ...
> RegionServer hang when aborting
> -------------------------------
>
> Key: HBASE-16960
> URL: https://issues.apache.org/jira/browse/HBASE-16960
> Project: HBase
> Issue Type: Bug
> Reporter: binlijin
> Assignee: binlijin
> Attachments: HBASE-16960.patch, RingBufferEventHandler.png,
> RingBufferEventHandler_exception.png, SyncFuture.png,
> SyncFuture_exception.png, rs1081.jstack
>
>
> We see regionserver hang when aborting several times and cause all regions on
> this regionserver out of service and then all affected applications stop
> works.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
