[
https://issues.apache.org/jira/browse/HBASE-17082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15669370#comment-15669370
]
stack commented on HBASE-17082:
-------------------------------
I reverted the first attempt with this commit:
{code}
commit 0f7a7f475134095eaa348af8fb78047970060ca0
Author: Michael Stack <[email protected]>
Date: Tue Nov 15 20:27:32 2016 -0800
Revert "HBASE-17082 ForeignExceptionUtil isnt packaged when building shaded
protocol with -Pcompile-protobuf; Attempted Fix"
This reverts commit 8847a7090260038afd538de274378a691ca96c4f.
We committed two 'attempted fixes'. This is a revert of the first
attempt. It did not work. Sorry for confusion. I used the same
commit message so it could be awkward unraveling.
{code}
> ForeignExceptionUtil isn’t packaged when building shaded protocol with
> -Pcompile-protobuf
> -----------------------------------------------------------------------------------------
>
> Key: HBASE-17082
> URL: https://issues.apache.org/jira/browse/HBASE-17082
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: ChiaPing Tsai
> Assignee: stack
> Fix For: 2.0.0
>
> Attachments: 17082_attempted_fix.txt, 17082_attempted_fix2.txt,
> HBASE-17082.nothing.patch, HBASE-17082.nothing.patch,
> HBASE-17082.nothing.patch, HBASE-17082.v0.patch, HBASE-17082.v1.patch,
> patch-unit-hbase-client (after v1.patch).txt, patch-unit-hbase-server (after
> v1.patch).txt
>
>
> The source folder will be replaced from src/main/java to
> project.build.directory/protoc-generated-sources when building shaded
> protocol with -Pcompile-protobuf, but we do not copy the
> ForeignExceptionUtil. So the final jar lacks the ForeignExceptionUtil and it
> causes the test error for hbase-client and hbase-server.
> {noformat}
> [ERROR]
> /testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:[169,36]
> cannot find symbol
> symbol: class ForeignExceptionUtil
> location: package org.apache.hadoop.hbase.util
> [ERROR]
> /testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java:[100,36]
> cannot find symbol
> symbol: class ForeignExceptionUtil
> location: package org.apache.hadoop.hbase.util
> [ERROR]
> /testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:[2144,17]
> cannot find symbol
> symbol: variable ForeignExceptionUtil
> location: class org.apache.hadoop.hbase.regionserver.HRegionServer
> [ERROR]
> /testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java:[938,32]
> cannot find symbol
> symbol: variable ForeignExceptionUtil
> location: class org.apache.hadoop.hbase.master.MasterRpcServices
> {noformat}
> This bug blocks the patches which are against the hbase-protocol-shaded
> module.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
