[
https://issues.apache.org/jira/browse/HBASE-17082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671517#comment-15671517
]
stack commented on HBASE-17082:
-------------------------------
You have a point. I add the below and pushed it:
commit 48439e57201ee3be5eb12e6187002501af305a35
Author: Michael Stack <[email protected]>
Date: Wed Nov 16 12:26:18 2016 -0800
HBASE-17082 ForeignExceptionUtil isnt packaged when building shaded
protocol with -Pcompile-protobuf; Attempted Fix; Add clarification to README.
diff --git a/hbase-protocol-shaded/README.txt b/hbase-protocol-shaded/README.txt
index 453a8d3..26a9665 100644
--- a/hbase-protocol-shaded/README.txt
+++ b/hbase-protocol-shaded/README.txt
@@ -33,6 +33,11 @@ or
$ mvn install -Pcompile-protobuf
NOTE: 'install' above whereas other proto generation only needs 'compile'
+NOTE: Unlike elsehwere the above command does NOT install this modules jar
+into the repo., intentionally. The jar made by the above is a scratch jar
+that is part of the process that gets us to a set of files to check in;
+it is not for consumption. Run mvn install without the '-Pcompile-protobuf'
+option to get this modules' artifact installed in your repo!
Let me know if you think we need more [~chia7712] Thanks.
> ForeignExceptionUtil isn’t packaged when building shaded protocol with
> -Pcompile-protobuf
> -----------------------------------------------------------------------------------------
>
> Key: HBASE-17082
> URL: https://issues.apache.org/jira/browse/HBASE-17082
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: ChiaPing Tsai
> Assignee: ChiaPing Tsai
> Fix For: 2.0.0
>
> Attachments: 17082_attempted_fix.txt, 17082_attempted_fix2.txt,
> HBASE-17082.nothing.patch, HBASE-17082.nothing.patch,
> HBASE-17082.nothing.patch, HBASE-17082.v0.patch, HBASE-17082.v1.patch,
> patch-unit-hbase-client (after v1.patch).txt, patch-unit-hbase-server (after
> v1.patch).txt
>
>
> The source folder will be replaced from src/main/java to
> project.build.directory/protoc-generated-sources when building shaded
> protocol with -Pcompile-protobuf, but we do not copy the
> ForeignExceptionUtil. So the final jar lacks the ForeignExceptionUtil and it
> causes the test error for hbase-client and hbase-server.
> {noformat}
> [ERROR]
> /testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:[169,36]
> cannot find symbol
> symbol: class ForeignExceptionUtil
> location: package org.apache.hadoop.hbase.util
> [ERROR]
> /testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java:[100,36]
> cannot find symbol
> symbol: class ForeignExceptionUtil
> location: package org.apache.hadoop.hbase.util
> [ERROR]
> /testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:[2144,17]
> cannot find symbol
> symbol: variable ForeignExceptionUtil
> location: class org.apache.hadoop.hbase.regionserver.HRegionServer
> [ERROR]
> /testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java:[938,32]
> cannot find symbol
> symbol: variable ForeignExceptionUtil
> location: class org.apache.hadoop.hbase.master.MasterRpcServices
> {noformat}
> This bug blocks the patches which are against the hbase-protocol-shaded
> module.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
