[ 
https://issues.apache.org/jira/browse/HBASE-16489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15674857#comment-15674857
 ] 

Enis Soztutar commented on HBASE-16489:
---------------------------------------

bq. The build/ directory is a temporary directory where we store object files, 
shared libs and other binaries on compilation. I can change the unit tests to 
create temporary xml configuration files under build/test-data
Sounds good. 
bq.  Also, We never delete from or write to /etc/hbase/conf. It is used only 
for reading.
Ok, but we cannot even assume that the machine running the unit test will have 
/etc/hbase/conf directory created. Better to confine everything under temp 
directories in build/test-data. 
bq. The idea behind using loader.Load(conf); was that we can use loader to load 
files from different search paths and use the same configuration object with 
the updated properties instead of using conf = loader.Load(); where a new 
object will be returned every time
It is fine to return a new object. In almost all of the usage, the user will be 
loding default file names from default search path. We do not need to 
complicate stuff for reloading using the same config object. Lets make it so 
that default usage is only 2 lines instead of 5 lines, similar to the HDFS 
Configuration case. 

> Configuration parsing
> ---------------------
>
>                 Key: HBASE-16489
>                 URL: https://issues.apache.org/jira/browse/HBASE-16489
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sudeep Sunthankar
>            Assignee: Sudeep Sunthankar
>         Attachments: HBASE-16489.HBASE-14850.v1.patch, 
> HBASE-16489.HBASE-14850.v2.patch, HBASE-16489.HBASE-14850.v3.patch, 
> HBASE-16489.HBASE-14850.v4.patch
>
>
> Reading hbase-site.xml is required to read various properties viz. 
> zookeeper-quorum, client retires etc.  We can either use Apache Xerces or 
> Boost libraries.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to