[
https://issues.apache.org/jira/browse/HBASE-16489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694576#comment-15694576
]
Sudeep Sunthankar commented on HBASE-16489:
-------------------------------------------
Thanks [~enis],
{quote}
This still assumes that the hbase source code is at /usr/src/hbase. Instead you
should use relative directories or find PWD and use $PWD/build or something.
{quote}.
I will use relative paths instead.
{quote}
The best way would be to add an assertion after the config parsing which
checks the conf optional is set.
{quote}
I will add the asserts in the subsequent patch and remove the 'if' conditions.
{quote}
Our precommit script (hadoopqa) checks for that for regular patches, but it is
not hooked up for this branch and C++ code yet.
{quote}
Is there a standalone script which I can use to check ?
{quote}
Also forgot to mention earlier that in java code base, we have a strict line
wrapping of 100 columns. Let's follow that in the C++ code base as well.
{quote}
I will change the line wrapping for all subsequent patches.
Thanks.
> Configuration parsing
> ---------------------
>
> Key: HBASE-16489
> URL: https://issues.apache.org/jira/browse/HBASE-16489
> Project: HBase
> Issue Type: Sub-task
> Reporter: Sudeep Sunthankar
> Assignee: Sudeep Sunthankar
> Attachments: HBASE-16489.HBASE-14850.v1.patch,
> HBASE-16489.HBASE-14850.v2.patch, HBASE-16489.HBASE-14850.v3.patch,
> HBASE-16489.HBASE-14850.v4.patch, HBASE-16489.HBASE-14850.v5.patch,
> HBASE-16489.HBASE-14850.v6.patch
>
>
> Reading hbase-site.xml is required to read various properties viz.
> zookeeper-quorum, client retires etc. We can either use Apache Xerces or
> Boost libraries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
